----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102444/ -----------------------------------------------------------
Review request for Amarok. Summary ------- One of the things that bugs me about Amarok is that if it crashes (as it tends to do on logout, for me), the playlist is lost, and next time you start it up it gives you the playlist from the last time it exited properly. This fixes that by auto-saving the playlist state. It schedules a save for 5 seconds in the future when a change is made to the playlist - any changes made withing those 5 seconds will not trigger a further save, but will be included in the scheduled save. This prevents the disk being hammered when making a flurry of changes. Possibly this timeout should be longer - 20 seconds? Diffs ----- ChangeLog ca2d6561ac607ad3dd4886a33a357f3add0b2eaf src/playlist/PlaylistModel.h 21e5f2ca8a4fdb2ccf77c8ea2b3cb47bf2a1c5e8 src/playlist/PlaylistModel.cpp 842095a11f649fd9a91f5bb53869ac607a552749 Diff: http://git.reviewboard.kde.org/r/102444/diff Testing ------- Changed the playlist, waited 5 seconds, killed amarok (killall -9 amarok). Starting up Amarok again displayed the modified playlist. Thanks, Alex
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
