----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102384/#review9989 -----------------------------------------------------------
This review has been submitted with commit 7913c4a58ebe010baf58dda825f2341d856ad2d7 by Ralf Engels to branch master. - Commit Hook On Aug. 26, 2011, 7:53 a.m., Nikhil Shantanu Marathe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102384/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2011, 7:53 a.m.) > > > Review request for Amarok and Bart Cerneels. > > > Description > ------- > > Cagibi 0.2.0 changed the D-BUS API including method locations and the return > format of deviceDetails. > At the same time, since Amarok still has KDE 4.4 as the lowest requirement, > Cagibi 0.1.0 compatibility is required. > > This patch adds support for both versions > > > Diffs > ----- > > src/core-impl/collections/upnpcollection/UpnpCollectionFactory.h f36030e > src/core-impl/collections/upnpcollection/UpnpCollectionFactory.cpp 9fdaa45 > src/core-impl/collections/upnpcollection/dbuscodec.h 158896e > src/core-impl/collections/upnpcollection/dbuscodec.cpp b6842cb > src/core-impl/collections/upnpcollection/deviceinfo.h 00b5b7f > > Diff: http://git.reviewboard.kde.org/r/102384/diff/diff > > > Testing > ------- > > Tested with one device, on both Cagibi 0.1.1 and 0.2.0 > > > Thanks, > > Nikhil Shantanu Marathe > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel