----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104449/ -----------------------------------------------------------
(Updated April 2, 2012, 1:37 p.m.) Review request for Amarok. Changes ------- Thanks for the comments, here's an updated patch (and screenshot). I've just applied for git access, so I'll commit once/if it's enabled. (The reason I used a QWeakPointer was because I had seen the same being done in the ExtendedAboutDialog (I now see why that is done there) -- I've changed it to a normal pointer.) (I'll do the changes to ScriptManager/PluginManager as described in https://bugs.kde.org/show_bug.cgi?id=296415#c4 as a separate patch when I next have time.) Description ------- Adds a diagnostics dialog to Amarok. This shows versions for KDE, QT, Phonon, the Phonon backend, and all scripts and plugins. As described in https://bugs.kde.org/show_bug.cgi?id=296415. This patch also changes/corrects PluginManager::plugins() to be const. This addresses bug 296415. https://bugs.kde.org/show_bug.cgi?id=296415 Diffs (updated) ----- src/CMakeLists.txt 6e590e8 src/MainWindow.h b149cb9 src/MainWindow.cpp 98b1c77 src/PluginManager.h 6b9f3ca src/PluginManager.cpp c46b12f src/dialogs/DiagnosticDialog.h PRE-CREATION src/dialogs/DiagnosticDialog.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/104449/diff/ Testing ------- Screenshots (updated) ----------- Screenshot of Dialog http://git.reviewboard.kde.org/r/104449/s/501/ Updated Screenshot (Version 2) http://git.reviewboard.kde.org/r/104449/s/502/ Thanks, Andrzej Hunt
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel