----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105221/#review14624 -----------------------------------------------------------
>From the code: 297 if ((*it)->mountType() == "nfs" || (*it)->mountType() == "nfs4" || 298 (*it)->mountType() == "smb" || (*it)->mountType() == "cifs") { (...) This was supposedly just for the network filesystems. Can anybody test with a collection folder on one of those network fs's? With positive results, we could even push to 2.6 final. - Matěj Laitl On June 11, 2012, 3:14 p.m., Matěj Laitl wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105221/ > ----------------------------------------------------------- > > (Updated June 11, 2012, 3:14 p.m.) > > > Review request for Amarok. > > > Description > ------- > > MediaDeviceCache: remove polling, solid events should suffice > > This fixes a bug where Amarok (very probably needlessly) polls solid > for all devices every single second (!!!) just to detect whether some > unmounted paths become mounted or vice versa. This should not be needed > at all, solid should notify us about everything. > > However, I am not sure, so this is definitely not a material for 2.6 > final but rather 2.7 if no problems show up. > > BUG: 289462 > FIXED-IN: 2.7 > REVIEW: 105221 > > > This addresses bug 289462. > https://bugs.kde.org/show_bug.cgi?id=289462 > > > Diffs > ----- > > src/MediaDeviceCache.h a48d453213e684d10b0a38b5b8ac01ae39680b52 > src/MediaDeviceCache.cpp 15583b8d4eb14f842242deaab18bc2d7033b5991 > > Diff: http://git.reviewboard.kde.org/r/105221/diff/ > > > Testing > ------- > > little > > > Thanks, > > Matěj Laitl > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel