----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106094/#review17733 -----------------------------------------------------------
I'll test if this solves my blocking problem when mounted NFS is inaccessible as well. - Bart Cerneels On Aug. 19, 2012, 10:52 p.m., Matěj Laitl wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106094/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2012, 10:52 p.m.) > > > Review request for Amarok. > > > Description > ------- > > {Smb,Nfs}DeviceHandler: use Solid instead of KMountPoint > > KMountPoint seems to be unreliable and not working at least for smb > shares. Use Solid's NetworkShare for the same task, which is much more > *cough* ... solid. :-) > > Server name & share name extraction changed a bit, but I've tested it > to give the same names as the old implementation. (not for some corner > cases, but old behaviour could be considered bogus there) > > BUG: 302837 > FIXED-IN: 2.7 > REVIEW: 106094 > > > This addresses bug 302837. > https://bugs.kde.org/show_bug.cgi?id=302837 > > > Diffs > ----- > > src/core-impl/collections/db/sql/device/nfs/NfsDeviceHandler.cpp > 74e19bc643d15f0f1473da7a6ca52a31583ffd83 > src/core-impl/collections/db/sql/device/smb/SmbDeviceHandler.cpp > 12d6c2a051f58579f1bdc69abeb7a1b0a049c5fa > > Diff: http://git.reviewboard.kde.org/r/106094/diff/ > > > Testing > ------- > > Medium, needs confirmation from bug reporter. > > > Thanks, > > Matěj Laitl > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
