----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108050/#review24379 -----------------------------------------------------------
Ship it! I don't know what that code is supposed to do, but if it's executed on each track change it likely is a real leak. Test if it doesn't cause dangling pointer crashes and ship it. - Bart Cerneels On Dec. 31, 2012, 2:06 p.m., Jekyll Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108050/ > ----------------------------------------------------------- > > (Updated Dec. 31, 2012, 2:06 p.m.) > > > Review request for Amarok. > > > Description > ------- > > I notice this when invesigating bug 298627. Amarok still leaks memory for me > , but at least it seems to leaks less now. > > > Diffs > ----- > > src/playlist/PlaylistBreadcrumbItemSortButton.cpp 95dba20 > > Diff: http://git.reviewboard.kde.org/r/108050/diff/ > > > Testing > ------- > > > Thanks, > > Jekyll Wu > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
