----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107473/ -----------------------------------------------------------
(Updated Jan. 15, 2013, 9:21 p.m.) Review request for Amarok. Changes ------- - Removed 'mutable' from PlailystFile members - Changed comments on setName method. I am also waiting for answer about loading playlists in a batches in PlaylistFileProvider. Description ------- I've started my changes with an implementation of a ASXPlaylist class, due this work I've found that implementation of different playlist file types has different logic, as result I end up with a rewriting playlist's implementations. As example of difference: -- Constructor M3UPlaylist::M3UPlaylist( const KUrl &url ) sets a url, but does not load playlist, therefore loading of playlist are posponed till data from playlist are actualy needed (lazy loading) On the other hand constructor XSPFPlaylist::XSPFPlaylist( const KUrl &url, bool autoAppend ) loads playlist. The main idea of proposed changes is to create a unify code for processing playlist files: -- lazy loading through LazyLoadPlaylist -- common functionality was moved to PlaylistFile. It is worth to be noticed that this patch changes structure of playlist's classes, bit does not changes their behavior, even if this behavior is inconsistent in some cases. In following patch-requests I plan to submit ASX Playlist parser and organize playlists processing in more consistent way. This addresses bug 291934. https://bugs.kde.org/show_bug.cgi?id=291934 Diffs (updated) ----- src/core-impl/playlists/types/file/PlaylistFile.h 4322da9 src/core-impl/playlists/types/file/xspf/XSPFPlaylist.h ebf3235 src/core/playlists/Playlist.h 8fd1ffb Diff: http://git.reviewboard.kde.org/r/107473/diff/ Testing ------- 1) All unit-tests were passed. 2) For all playlists I've also checked loading and saving through gui. Thanks, Tatjana Gornak
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel