> On Feb. 9, 2013, 5:36 p.m., Matěj Laitl wrote: > > src/MainWindow.cpp, line 836 > > <http://git.reviewboard.kde.org/r/108716/diff/2/?file=113315#file113315line836> > > > > Amarok coding style says: > > > > connect( action, SIGNAL(triggered(bool)), this, > > SLOT(slotShufflePlaylist()) ); > > > > (note that SIGNAL/SLOT macros are the only exception when there are no > > spaces around arguments)
Thanks of pointing out minor details. I have fixed all the above things but in the process I some how deleted one patch file. So I tried to create patch using "git format-patch commit-tag --stdout > patchfile" but it appears that there is something wrong with the patch. Please help. Thanks again. - Harsh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108716/#review27059 ----------------------------------------------------------- On Feb. 10, 2013, 2:21 a.m., Harsh Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108716/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2013, 2:21 a.m.) > > > Review request for Amarok. > > > Description > ------- > > Added a shortcut button for shuffle with default shortcut as Ctrl + H. > Created a slot shuffleTrack() in mainWindow.cpp which is triggered on > pressing Ctrl + H > > > This addresses bug 208061. > https://bugs.kde.org/show_bug.cgi?id=208061 > > > Diffs > ----- > > src/MainWindow.cpp 8587784 > src/MainWindow.cpp 8587784 > src/MainWindow.h 4b23679 > ChangeLog 139ffa5 > ChangeLog 749ed6d > > Diff: http://git.reviewboard.kde.org/r/108716/diff/ > > > Testing > ------- > > All tests passed. > > > Thanks, > > Harsh Gupta > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel