> On Feb. 11, 2013, 5:40 p.m., Bart Cerneels wrote: > > Use a promoted widget instead. UI forms superior to this, we prefer to use > > them more, not less. > > > > FYI the QueueEditor feature is not something we'll keep around for long. > > It's scheduled to be completely replaced one or two releases from now. > > Consider that before you spend days of useful coding time on it.
http://qt-project.org/doc/qt-4.8/designer-using-custom-widgets.html - Bart ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108905/#review27217 ----------------------------------------------------------- On Feb. 11, 2013, 10:39 a.m., Bartosz Szreder wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108905/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2013, 10:39 a.m.) > > > Review request for Amarok. > > > Description > ------- > > This is the first patch (of two) resolving bug #263563 > > I need to create a specialized QListWidget implementation. Thus it seems > easier to move the rather limited part of UI into the .cpp file and cleanly > add another class with the desired modifications than to dig into .ui files > with nonstandard classes. > > This patch shouldn't introduce any changes in behavior yet. It's only purpose > is to prepare ground for the next patch. > > > This addresses bug 263563. > https://bugs.kde.org/show_bug.cgi?id=263563 > > > Diffs > ----- > > src/playlist/PlaylistQueueEditor.h 40b8cdf > src/playlist/PlaylistQueueEditor.cpp f647e37 > src/playlist/PlaylistQueueEditor.ui a05cafd > src/CMakeLists.txt 043dc64 > > Diff: http://git.reviewboard.kde.org/r/108905/diff/ > > > Testing > ------- > > Tested on two different instalations, no regressions noticed. > > > Thanks, > > Bartosz Szreder > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
