> On Feb. 26, 2013, 4:25 p.m., Matěj Laitl wrote: > > src/dialogs/EqualizerDialog.cpp, lines 99-119 > > <http://git.reviewboard.kde.org/r/108995/diff/1/?file=114229#file114229line99> > > > > Ugly. Instead please: > > a) check whether meqBandFrq (horrible variable name btw, not your > > fault) has 10 items or 11. > > b) don't append preamp to mBands, mBandsValues, mBandsLabels in case it > > is not available.
Reason for appending preamp : Since number of sliders are hard coded in UI ( 11 sliders ) I thought each slider should have some label. Anyway I will remove preamp label and make first 10 sliders active while last slider is disabled. - Harsh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108995/#review28117 ----------------------------------------------------------- On Feb. 18, 2013, 11:38 a.m., Harsh Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108995/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2013, 11:38 a.m.) > > > Review request for Amarok. > > > Description > ------- > > 1. Disabled Pre-amplifier in equalizer if it is not supported by phonon. > 2. Fixed top and bottom labels of first slider. Earlier band name label was > at the top and slider value label was at the bottom for first slider. > 3. Removed an extra semicolon EqualizerDialog.h . > Note : I have made an assumption that if at all preamp is present then it > will the first element of Effect Parameter list. > > > This addresses bug 301311. > https://bugs.kde.org/show_bug.cgi?id=301311 > > > Diffs > ----- > > src/dialogs/EqualizerDialog.ui 43b0187 > src/EngineController.cpp 3577acf > src/dialogs/EqualizerDialog.h fd9032b > src/dialogs/EqualizerDialog.cpp 63d8209 > > Diff: http://git.reviewboard.kde.org/r/108995/diff/ > > > Testing > ------- > > All unit test cases passed. > Note : I have tested it with gstreamer only. Xine phonon keep crashing on my > PC. > > > File Attachments > ---------------- > > Equalizer snapshot > http://git.reviewboard.kde.org/media/uploaded/files/2013/02/17/equalizer.png > > > Thanks, > > Harsh Gupta > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel