-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109846/
-----------------------------------------------------------

(Updated April 4, 2013, 2:39 a.m.)


Review request for Amarok.


Description
-------

1. Added "Suspend Options" to the PlaybackConfig Dialog, with two options:
     Pause playback on suspend
     Inhibit suspend if playing
2. Created a PowerManager class to handle suspend behavior

Fixes:
BR 259862 - Amarok does not inhibit suspend while playing 
BR 301512 - Amarok does not prevent machine from sleeping when music is playing 
BR 222571 - Amarok pause on suspend 


Diffs (updated)
-----

  src/configdialog/dialogs/PlaybackConfig.ui 3a79e43 
  src/amarokconfig.kcfg fbe5497 
  src/PowerManager.cpp PRE-CREATION 
  src/PowerManager.h PRE-CREATION 
  src/CMakeLists.txt 990f313 
  src/EngineController.cpp 52bfd90 

Diff: http://git.reviewboard.kde.org/r/109846/diff/


Testing
-------

Works as expected


File Attachments
----------------

PlaybackConfig Dialog
  http://git.reviewboard.kde.org/media/uploaded/files/2013/04/03/snapshot11.png


Thanks,

Anmol Ahuja

_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Reply via email to