> On April 25, 2013, 3:43 p.m., Edward Hades Toroshchin wrote: > > Thanks for the fix. However, this is the approach, we've used originally, > > and it didn't prove very reliable. I think we even went back and forth more > > than once. > > > > So you should really have a look in the history of the mysql collection, to > > see if and how this is different from the way it's been done before (and > > why it isn't done that way anymore). > > > > > This fixes an issue where amarok is writing the database to "C:\Program > > > Files (x86)\Amarok\data\amarok". > > > This issue prevents Amarok from running correctly, because regarding to > > > the rights of the useraccount the directory can be not writeable. > > > > It's not only that, it could also lead to problems if several users tried > > to use Amarok simultaneously. > > > > I suggest you check, where does this path come from. Why is storageLocation > > empty? > > Patrick von Reth wrote: > Storage location is not empty but either mysql isn't using MYSQL_HOME or > unable to read the file. > Why should it be a problem if several user are running amarok, what would > be the difference to the my.cnf approach. >
> Why should it be a problem if several user are running amarok, what would be > the difference to the my.cnf approach. No, I was talking about the my.cnf approach, since the my.cnf file would be in the same place for different users. - Edward Hades ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110187/#review31576 ----------------------------------------------------------- On April 25, 2013, 2:36 p.m., Patrick von Reth wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110187/ > ----------------------------------------------------------- > > (Updated April 25, 2013, 2:36 p.m.) > > > Review request for Amarok. > > > Description > ------- > > Don't communicate with mysql by env vars and autogenerated files > > Instead of generating the my.cnf every time amarok starts and to pass > the location of this file by setting an environment variable directly > pass the settings as arguments to mysql. As this is probably a better > approach and the only one working on windows. > > This fixes an issue where amarok is writing the database to "C:\Program Files > (x86)\Amarok\data\amarok". > This issue prevents Amarok from running correctly, because regarding to the > rights of the useraccount the directory can be not writeable. > > The commands used are taken from the output of "mysqld --verbose --help". > > > Diffs > ----- > > src/core-impl/collections/db/sql/mysqlecollection/MySqlEmbeddedStorage.cpp > 0233498fdeb18ab51e709e9a78384fc37c47cb2a > > Diff: http://git.reviewboard.kde.org/r/110187/diff/ > > > Testing > ------- > > Only on windows > > > Thanks, > > Patrick von Reth > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
