----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110426/ -----------------------------------------------------------
(Updated May 20, 2013, 1:15 p.m.) Review request for Amarok. Description ------- I have created a KWalletHelper class so that services like Maganatune, Last.fm and GPodder can use this rather than duplicating code. Currently the patch applies only to Magnatune. The KWalletHelper class complies but it doesn't link properly to the MagnatuneConfig class. Diffs ----- src/CMakeLists.txt 4dcb316 src/services/KWalletHelper.h e69de29 src/services/KWalletHelper.cpp e69de29 src/services/magnatune/CMakeLists.txt 91f24c0 src/services/magnatune/MagnatuneConfig.h 552bcf8 src/services/magnatune/MagnatuneConfig.cpp 5842c63 Diff: http://git.reviewboard.kde.org/r/110426/diff/ Testing ------- The KWalletHelper.cpp complies but fails to link to ManatuneConfig.cpp. Output of "make" command: http://paste.kde.org/743792/ File Attachments (updated) ---------------- http://git.reviewboard.kde.org/media/uploaded/files/2013/05/20/walletHelperv3.patch Thanks, Vedant Agarwala
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
