> On June 8, 2013, 9:02 a.m., Vedant Agarwala wrote: > > Seems like a good patch. Did you test it with any script? It will be better > > if you do and even better if you attach a screen shot of that depicts the > > working.
Thanks for your review, Vedant. We welcome patch reviews from non-members of the core Amarok team and you've pointed out things I would point out too (method name, trailing whitespace, style..). However, please state that you are not (yet) a member of the core Amarok development team in such reviews to reduce any possible confusion. Best is probably to present the review as a couple of non-binding friendly suggestions from a fellow contributor, not necessarily endorsed by The Amarok Team. - Matěj ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110855/#review33930 ----------------------------------------------------------- On June 8, 2013, 8:32 p.m., Shubham Chaudhary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110855/ > ----------------------------------------------------------- > > (Updated June 8, 2013, 8:32 p.m.) > > > Review request for Amarok. > > > Description > ------- > > Bug 205509 - JJ: add dbus functions to update podcasts and download podcast > tracks > I added two new methods for dbus: UpdateAllPodcast and AddPodcast > > > This addresses bugs 205509 and Bug. > https://bugs.kde.org/show_bug.cgi?id=205509 > https://bugs.kde.org/show_bug.cgi?id=Bug > > > Diffs > ----- > > src/dbus/mpris1/org.freedesktop.MediaPlayer.tracklist.xml ee512b7 > src/dbus/mpris1/TrackListHandler.cpp b1f01cf > src/dbus/mpris1/TrackListHandler.h 551999a > > Diff: http://git.reviewboard.kde.org/r/110855/diff/ > > > Testing > ------- > > Tested both of these methods using qdbus > qdbus org.kde.amarok /TrackList AddPodcast > "http://feeds.feedburner.com/freakonomicsradio"; > qdbus org.kde.amarok /TrackList UpdateAllPodcast > > > Thanks, > > Shubham Chaudhary > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
