----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111510/#review36044 -----------------------------------------------------------
Ship it! Sharing code is so much better than reinventing the wheel, thank you for the patch! (yes, I see it is already merged) - Matěj Laitl On July 16, 2013, 11:37 a.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111510/ > ----------------------------------------------------------- > > (Updated July 16, 2013, 11:37 a.m.) > > > Review request for Amarok. > > > Description > ------- > > Consistently use FindFFMpeg.cmake from kdelibs > > FindFFMpeg from kdelibs works differently to our internal one (and, in > fact, more consistently with standard Find* files). Since we depends on > kdelibs anyway, we now just use the kdelibs one and don't bother > shipping our own. > > > Diffs > ----- > > ChangeLog 5fe5d2e64c771d722f3f90bf6c98d5013e56553c > cmake/modules/FindFFmpeg.cmake 0aa2cdc33a88953fe8b94532cb45c43ad35e0da8 > src/CMakeLists.txt 589fddb9ea2177102cabd3a193a9e6848ea9c12d > > Diff: http://git.reviewboard.kde.org/r/111510/diff/ > > > Testing > ------- > > Build works with FFMpeg and libOFA installed, and kdelibs 4.10.5. No other > configurations tested. (Without the patch, the build fails with this > configuration). > > > Thanks, > > Alex Merry > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
