-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111824/
-----------------------------------------------------------
(Updated July 31, 2013, 6:22 p.m.)
Review request for Amarok.
Description
-------
I created a new runnable class that performs transcoding of a single track
(IpodCopySingleTrack). I updated the existing code in IpodCopyTracksJob,
renamed it to IpodCopyTracks (since it does not extend ThreadWeaver::Job
anymore) and ported some of it to IpodCopySingleTrack.
This addresses bug 317093.
https://bugs.kde.org/show_bug.cgi?id=317093
Diffs
-----
src/core-impl/collections/ipodcollection/CMakeLists.txt cb4ef06
src/core-impl/collections/ipodcollection/IpodCollection.h 02e55f8
src/core-impl/collections/ipodcollection/IpodCollectionLocation.h cc27e19
src/core-impl/collections/ipodcollection/IpodCollectionLocation.cpp f8105f9
src/core-impl/collections/ipodcollection/jobs/IpodCopySingleTrack.h
PRE-CREATION
src/core-impl/collections/ipodcollection/jobs/IpodCopySingleTrack.cpp
PRE-CREATION
src/core-impl/collections/ipodcollection/jobs/IpodCopyTracks.h PRE-CREATION
src/core-impl/collections/ipodcollection/jobs/IpodCopyTracks.cpp PRE-CREATION
src/core-impl/collections/ipodcollection/jobs/IpodCopyTracksJob.h 0258bf2
src/core-impl/collections/ipodcollection/jobs/IpodCopyTracksJob.cpp a7fd97e
Diff: http://git.reviewboard.kde.org/r/111824/diff/
Testing
-------
Builds and installs but I could not test actual transcoding since I do not have
an iPod.
Thanks,
Vedant Agarwala
_______________________________________________
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
