----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111991/ -----------------------------------------------------------
(Updated Aug. 10, 2013, 4:44 p.m.) Review request for Amarok. Changes ------- Take Marks review into account Description ------- If an UMS-collection is non-writeable (think freshly created ext4 on an USB-stick) a copy/move to collection will silently fail. It can only be seen in the debug logs on the console. The reason is that the UMS-collection is not actually checking if its writeable. Its just assuming to be always writeable. My change consists of two parts: 1. I check if the UMS-collection is actually writeable (mount point and if set the "music folder"). 2. To give the user a hint what is going on I added a warning message, informing the user that this collection is read-only (otherwise he might be confused why certain operations (move/copy/organize) are missing. Diffs (updated) ----- src/core-impl/collections/umscollection/UmsCollection.h 749ff81 src/core-impl/collections/umscollection/UmsCollection.cpp 028966e src/core-impl/collections/umscollection/UmsCollectionLocation.cpp 1cd1ba8 Diff: http://git.reviewboard.kde.org/r/111991/diff/ Testing ------- I have tested with an USB-Stick containing an ext4 filesystem. First i had the base-dir owned by root.root (non-writeable), next i made it writeable and verified that its correctly detected as such. Next i created a "Music" folder and configured it for this USB-Stick. I checked that it was detected as writeable. Next i made the "Music" folder non-writeable and checked that amarok also detected that. Thanks, Frank Meerkoetter
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
