----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112255/#review38506 -----------------------------------------------------------
Ship it! Looks good to me, please merge. Dunno how that could have been left broken for such a long time. - Matěj Laitl On Aug. 25, 2013, 12:11 a.m., Frank Meerkoetter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112255/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2013, 12:11 a.m.) > > > Review request for Amarok. > > > Description > ------- > > When Setting->Config->Metadata->Write covers to file is enabled, it should be > possible to write covers for albums located on an UMS collection. The current > status is that amarok does the write but never updates itself to reflect the > new cover. There is code to achive this but is has been broken at some point. > > /home/frank/kde/src/amarok/src/core-impl/meta/file/File_p.h:358 tries to > create a signal/slot connection (to re-read the tags after the write is done) > to an invalid slot. This is fixed by my patch. > > > Diffs > ----- > > src/core-impl/meta/file/File.cpp f2abea4 > src/core-impl/meta/file/File_p.h 40f631c > > Diff: http://git.reviewboard.kde.org/r/112255/diff/ > > > Testing > ------- > > Writing album covers for files located on an USB stick. > The album is updated now (collection browser, playlist). The current track > applet isn't updating but i guess this is a different problem. > > > Thanks, > > Frank Meerkoetter > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
