> On May 6, 2014, 12:58 a.m., Albert Astals Cid wrote: > > Has this been commited? Yuri can you commit it? Want me to commit it? > > Yuri Chornoivan wrote: > I just wanted that it to be committed by the team leader (Mat?j). Please > commit the patch if you find this appropriate. ;) > > Albert Astals Cid wrote: > No no no, don't shift the "if you find this appropiate" to me, you either > give it a "ship it" and take full responsability for it or should not give > ship it anymore.
Albert, Yuri, Matej is too busy, so just ship it. - Myriam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114752/#review57368 ----------------------------------------------------------- On Jan. 5, 2014, 3:17 p.m., Abhay Sombanshi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114752/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2014, 3:17 p.m.) > > > Review request for Amarok and Yuri Chornoivan. > > > Bugs: 291400 > https://bugs.kde.org/show_bug.cgi?id=291400 > > > Repository: amarok > > > Description > ------- > > CollectionBrowser filter dialog will now allow a length of 24 hours. > > > Diffs > ----- > > ChangeLog 0eb03c8 > src/widgets/MetaQueryWidget.cpp 58601cc > > Diff: https://git.reviewboard.kde.org/r/114752/diff/ > > > Testing > ------- > > works as expected. > > > Thanks, > > Abhay Sombanshi > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
