2014-12-14 13:38 GMT+01:00 Matěj Laitl <ma...@laitl.cz>: > On 14. 12. 2014 Konrad Zemek wrote: >> >> Git submodule approach looks promising, however I have some concerns: >> >> a) this makes test depend on 'your' github repositories; we cannot >> >> guarantee they won't go away etc. >> >> b) this makes testing Amarok require internet connection, at least >> >> initially; this of shipping entire sources to build a distribution >> >> package etc. >> >> c) circumvents source file checksumming etc. that many distributions do >> >> to enhance security >> >> d) is it legally okay to redistribute googlemock, googletest? Using a >> >> git repo, shipping a tarball? >> >> >> >> Still, I like the idea. a) seems easily fixable b), c) seems fixable by >> >> tweaking the way we create Amarok tarballs. >> > >> > I guess a) can be easily fixed if this goes to our git repo. >> > as for d) since googlemock is Free Software (New BSD 3 clause license, see >> > also https://code.google.com/p/googlemock/), this shouldn't be a problem. >> >> As for b) and c), I was imagining that `git submodule update --init` >> would become a standard step to fetch sources for creating a tarball >> or building tests. The auto-fetch is there just for convenience. > > Thinking about it more, this should work. Initially I was thinking about how > distros ship packages, but this should not touch binary distros at all. > > How big is tarballed gtest + gmock? Can we just embed them in our release > tarballs? Else we can create something like amarok-testlibs-$version.tar.bz2, > but that would be more work and effort.
tarred and bzipped, the repos take 588KB of space (tbz2 of the whole Amarok source is 158MB). I can look into shallow clones if needed. Konrad _______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel