----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121564/ -----------------------------------------------------------
(Updated Dec. 16, 2014, 8:44 p.m.) Review request for Amarok. Repository: amarok Description ------- The submodules are used to build googlemock for linking with test suites. The submodules are intended to be fetched by a user through `git submodule` commands, but for convenience can also be automatically fetched when processing tests' CMakeLists.txt . If the simple logic in CMakeLists.txt determines that the submodules couldn't be fetched, it aborts configuration with a meaningful error message. Diffs ----- .gitmodules PRE-CREATION cmake/modules/FindGooglemock.cmake b8ac8152075a18e8add34e06e920dffde15428ae tests/CMakeLists.txt 9f0a5ddbcb0318b2f348fed2e0a15e726834e332 Diff: https://git.reviewboard.kde.org/r/121564/diff/ Testing ------- Compilation with and without testing enabled, with and without git available. Release build done with help of releaseme.git:amarok2.rb script. Thanks, Konrad Zemek
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
