-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127468/
-----------------------------------------------------------
Review request for Amarok.
Bugs: 339190
https://bugs.kde.org/show_bug.cgi?id=339190
Repository: amarok
Description
-------
Home-burned or old audio CDs usually don't have CDTEXT, that is what was
triggering the bug.
The bug was releted to poor management of track names, that are generated using
the pattern "Track%1.wav".
The audiocd:/ KIO protocol requires that a device is also added to the URL, and
this was not done everywhere.
Lack of device was triggering an unexpected/strange behaviour in some KDE
function making Amarok enter an infinite loop.
Diffs
-----
src/core-impl/collections/audiocd/AudioCdCollection.h dc2cad7
src/core-impl/collections/audiocd/AudioCdCollection.cpp 3dfa7c3
Diff: https://git.reviewboard.kde.org/r/127468/diff/
Testing
-------
First I reproduced the bug with an original CD 100% of the times. It was
triggered in case the CD didn't have any CDTEXT. Only in that case the
noInfoAvailable function was invoked.
After fixing it, I verified that it works as expected both with CDs with CDTEXT
and CDs without it.
Thanks,
Stefano Pettini
