----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129055/#review100036 -----------------------------------------------------------
Ship it! Looks good. Feel free to push if you have commit access. Since kf5 is a development branch and there are few people to review, feel free to push to it directly unless you explicitly want a review (perhaps for something controversial). - Matěj Laitl On Zář. 27, 2016, 10:13 odp., Alexandr Akulich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129055/ > ----------------------------------------------------------- > > (Updated Zář. 27, 2016, 10:13 odp.) > > > Review request for Amarok. > > > Repository: amarok > > > Description > ------- > > There is a change at commit c3c4c7b8ebc4bc9ec94394f5d3a5569dee8b4725 : > ```diff > setText( i18n( "Play/Pause" ) ); > - setShortcut( Qt::Key_Space ); > - setGlobalShortcut( KShortcut() ); > + KGlobalAccel::setGlobalShortcut(this, QKeySequence(Qt::Key_Space) ); > ``` > > The change globally binds Key_Space, which breaks the key usage for the > session. > > > Diffs > ----- > > src/ActionClasses.cpp 77334fc > > Diff: https://git.reviewboard.kde.org/r/129055/diff/ > > > Testing > ------- > > Compiles. > > > Thanks, > > Alexandr Akulich > >