pgomes created this revision.
pgomes created this object with edit policy "Administrators".
pgomes added a project: Amarok.
Herald added subscribers: amarok-devel, Amarok.
Herald removed a project: Amarok.
pgomes requested review of this revision.

REVISION SUMMARY
  Cmake reports the following error when processing metadata.desktop file for 
Amarok's applets: lyrics, analyzer, wikipedia, etc.
  
    CMake Warning at 
/usr/lib/x86_64-linux-gnu/cmake/KF5Package/KF5PackageMacros.cmake:127 (message):
      couldn't generate metainfo for org.kde.amarok.wikipedia:
  
  The error is because such .desktop files do not have a  "Comment=" field. I 
have added such to all files

TEST PLAN
  Run cmake and see that the error is not preset.

REPOSITORY
  R181 Amarok

REVISION DETAIL
  https://phabricator.kde.org/D27370

AFFECTED FILES
  src/context/applets/albums/package/metadata.desktop
  src/context/applets/analyzer/package/metadata.desktop
  src/context/applets/currenttrack/package/metadata.desktop
  src/context/applets/lyrics/package/metadata.desktop
  src/context/applets/photos/package/metadata.desktop
  src/context/applets/wikipedia/package/metadata.desktop

To: pgomes
Cc: #amarok, amarok-devel

Reply via email to