> Doesn't compile on Windows using VS2008:
> C:\dev\src\amarok-2.3.90\src\core\transcoding\TranscodingController.cpp(30)
> : error C2491: 'The::transcodingController' : definition of dllimport
> function not allowed
Since I don't run Windows, I would greatly appreciate if you could
please check if the attached patch fixes the build issue.
Cheers
--
Teo
From b93953693819fd85ef37724585094a0037f5476e Mon Sep 17 00:00:00 2001
From: Teo Mrnjavac <[email protected]>
Date: Tue, 7 Dec 2010 22:12:38 +0100
Subject: [PATCH] Removed useless AMAROK_EXPORT in a method's definition.
---
src/core/transcoding/TranscodingController.cpp | 2 +-
src/core/transcoding/TranscodingController.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/core/transcoding/TranscodingController.cpp b/src/core/transcoding/TranscodingController.cpp
index 49d8b22..9f25c7f 100644
--- a/src/core/transcoding/TranscodingController.cpp
+++ b/src/core/transcoding/TranscodingController.cpp
@@ -26,7 +26,7 @@
namespace The
{
-AMAROK_EXPORT Transcoding::Controller *transcodingController()
+Transcoding::Controller *transcodingController()
{
return Transcoding::Controller::instance();
}
diff --git a/src/core/transcoding/TranscodingController.h b/src/core/transcoding/TranscodingController.h
index 016ddd8..54848c0 100644
--- a/src/core/transcoding/TranscodingController.h
+++ b/src/core/transcoding/TranscodingController.h
@@ -72,7 +72,7 @@ private:
namespace The
{
- AMAROK_EXPORT Transcoding::Controller *transcodingController();
+ AMAROK_CORE_EXPORT Transcoding::Controller *transcodingController();
}
#endif //TRANSCODING_CONTROLLER_H
--
1.7.3.2
_______________________________________________
Amarok mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/amarok
