Mark Martinec wrote the following on 16/12/2006 01:35: > Alan, > >> In 2.4.4 I've uncommented the "# , p0f=?" in the sql statement. As this is >> not logging into the p0f field in msgs I presumed some additional changes >> are still required? > > The ->execute part of the patch is needed too. > > Here is the same patch, but made against 2.4.4: > > --- amavisd~ Mon Nov 20 18:35:40 2006 > +++ amavisd Sat Dec 16 02:32:54 2006 > @@ -859,5 +859,5 @@ > 'upd_msg' => > 'UPDATE msgs SET content=?, quar_type=?, quar_loc=?, dsn_sent=?,'. > - ' spam_level=?, message_id=?, from_addr=?, subject=?'. # ,p0f=? > + ' spam_level=?, message_id=?, from_addr=?, subject=?, p0f=?'. > ' WHERE mail_id=?', > 'ins_rcp' => > @@ -14518,11 +14518,11 @@ > for ($quar_type,$content_type) { $_ = ' ' if !defined || /^ *\z/ } > do_log(4,"save_info_final %s, %s, %s, %s, %s, %s, ". > - "Message-ID: %s, From: '%s', Subject: '%s'", > + "Message-ID: %s, From: '%s', Subject: '%s', p0f: '%s'", > $mail_id, $content_type, $quar_type, $q_to, $dsn_sent, > - $spam_level, $m_id, $from, $subj); > + $spam_level, $m_id, $from, $subj, $os_fp); > # update message record with additional information > $conn_h->execute($sql_cl_r->{'upd_msg'}, > $content_type, $quar_type, $q_to, $dsn_sent, > - 0+untaint($spam_level), $m_id, $from, $subj, # $os_fp, > + 0+untaint($spam_level), $m_id, $from, $subj, $os_fp, > $mail_id); > # SQL_CHAR, SQL_VARCHAR, SQL_VARBINARY, SQL_BLOB, SQL_INTEGER, SQL_FLOAT, > > >
Mark I've not looked at 2.5 yet, have you included a mechanism to allow p0f sql logging to be configured? Thanks Alan ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ AMaViS-user mailing list AMaViS-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/amavis-user AMaViS-FAQ:http://www.amavis.org/amavis-faq.php3 AMaViS-HowTos:http://www.amavis.org/howto/