[ 
https://issues.apache.org/jira/browse/AMBARI-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13624993#comment-13624993
 ] 

Mahadev konar commented on AMBARI-1760:
---------------------------------------

Michael,
 Thanks for the patch. The patch looks good. A couple of comments:

 - the indentation is 2 space (no tabs) for python code as well
 - can you provide a unit test for this as well? Take a look at the python unit 
tests in the ambari-server (src/test/python/TestAmbaryServer.py )  to see how 
to add one. 

Other than that this looks good. Thanks a lot!
                
> Allow ambari-server client.api.port to be configured during setup.
> ------------------------------------------------------------------
>
>                 Key: AMBARI-1760
>                 URL: https://issues.apache.org/jira/browse/AMBARI-1760
>             Project: Ambari
>          Issue Type: Improvement
>    Affects Versions: 1.2.2
>            Reporter: Michael Harp
>            Priority: Minor
>              Labels: configuration
>             Fix For: 1.3.0
>
>         Attachments: AMBARI-1760
>
>
> Allow client.api.port to be configured during ambari-server setup. 
> Something like this;
> ambari-server setup -j /usr/java/default -p 8085

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to