[
https://issues.apache.org/jira/browse/AMBARI-3672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13816305#comment-13816305
]
Sumit Mohanty commented on AMBARI-3672:
---------------------------------------
Few comments:
==
Not part of this patch but can you rename the input parameter?
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
HeartbeatMonitor(Clusters fsm, <--
==
ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java
getEffectiveDesiredTags() - Comments "override (1) with service-specific
overrides" and "override (2) with host-specific overrides" are no longer
applicable. And, the code now collects all tags and does not do any override.
Line 280: if (serviceInfo.hasPropertyFor(type, keys) ||
!hasPropertyFor(stackId, type, keys))
For types that are not global why don't we just declare the SCH to be "stale"
when actual does not contain the "type". I think the per property check sounds
risky in two ways - too many properties to check and assumes that the stack
definition is maintained correctly wrt. property mapping.
Line 273: if (!serviceInfo.hasConfigType(type))
We should have a JIRA to make sure that the mapping of type to service is
verified for 1.3.2, 1.3.3 and 2.0.6. Can you open one?
Line 384: desiredSet.removeAll(actualSet);
Isn't this only true if the size of the sets are the same?
Line 294: Collection<String> changed = findChangedKeys(cluster, type,
tags.values(), actualTags.values());
Should we do it only for "global"?
==
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java
No change in this file.
==
asf-ambari/ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java
public Map<String, DesiredConfig> getDesiredConfigs(long clusterId) <-- this
should be removed, is it being done through another JIRA?
Do we have a unit test for agent returning actual config in the old form and it
being handled by server? I am thinking upgrade.
> Add Support to AmbariManagementController to derive configs from Config groups
> ------------------------------------------------------------------------------
>
> Key: AMBARI-3672
> URL: https://issues.apache.org/jira/browse/AMBARI-3672
> Project: Ambari
> Issue Type: Task
> Components: controller
> Affects Versions: 1.4.2
> Reporter: Siddharth Wagle
> Assignee: Siddharth Wagle
> Fix For: 1.4.3
>
> Attachments: AMBARI-3672-1.patch, AMBARI-3672.patch
>
>
> Application of the configurations boils down to figuring out the configs for
> a Service Host Component when a Task is to be created for the host. Rules to
> apply configuration changes:
> - Apply cluster desired configs
> - Get all the config groups for the host
> - Apply the overrides per config type. (In future this can go through config
> groups for service then component and host component in that order)
--
This message was sent by Atlassian JIRA
(v6.1#6144)
