Agreed, just worried about the name, it doesn't sounds as a proper Config, but I can't think better :)
http://people.apache.org/~simonetripodi/ http://www.99soft.org/ On Fri, Jul 9, 2010 at 11:32 AM, Pid <[email protected]> wrote: > On 08/07/2010 22:16, [email protected] wrote: >> Author: pidster >> Date: Thu Jul 8 21:16:34 2010 >> New Revision: 961940 >> >> URL: http://svn.apache.org/viewvc?rev=961940&view=rev >> Log: >> Incorporate storage mechanisms into the server API, (protected methods will >> be hidden from users but accessible to the implementation) >> >> Modified: >> >> incubator/amber/trunk/spec-api/src/main/java/org/apache/amber/server/OAuthServer.java >> >> Modified: >> incubator/amber/trunk/spec-api/src/main/java/org/apache/amber/server/OAuthServer.java >> URL: >> http://svn.apache.org/viewvc/incubator/amber/trunk/spec-api/src/main/java/org/apache/amber/server/OAuthServer.java?rev=961940&r1=961939&r2=961940&view=diff >> ============================================================================== >> --- >> incubator/amber/trunk/spec-api/src/main/java/org/apache/amber/server/OAuthServer.java >> (original) >> +++ >> incubator/amber/trunk/spec-api/src/main/java/org/apache/amber/server/OAuthServer.java >> Thu Jul 8 21:16:34 2010 >> @@ -26,4 +26,19 @@ package org.apache.amber.server; >> */ >> public abstract class OAuthServer implements OAuthnServer, OAuthzServer { >> >> + /** >> + * @return access storage >> + */ >> + protected abstract AccessStorage getAccessStorage(); >> + >> + /** >> + * @return consumer storage >> + */ >> + protected abstract ConsumerStorage getConsumerStorage(); >> + >> + /** >> + * @return token storage >> + */ >> + protected abstract TokenStorage getTokenStorage(); >> + >> } >> >> > > I'm thinking about reverting this change and adding those methods to an > OAuthServerConfig interface instead, which is passed into the constructor: > > // > protected OAuthServer(OAuthServerConfig config) { > this.config = config; > } > > // > protected OAuthServerConfig getConfig() { > return this.config; > } > > > This would mean that the whole storage concept and other configuration > can be handled and configured in the factory during OAuthServer creation. > > Thoughts? > > > p > >
