[ 
https://issues.apache.org/jira/browse/AMBER-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13530842#comment-13530842
 ] 

Stein Welberg commented on AMBER-64:
------------------------------------

Hi Antonio,

My patch actually at the moment doesn't solve the problem of the double use 
case that the QueryParameterApplier aims to solve (I wasn't aware of the fact 
that it was also being used in the OAuth client part). However, I don't think 
that it is a lot of work to refactor it in such a way that both the clients' 
and authorization server' use cases are supported :-). So maybe we should 
propose such a way so the other appliers can also be refactored accordingly? 
WDYT?


off topic: I think you are right, however I haven't looked into the other 
appliers in much detail. 
                
> QueryParameterApplier needs to include the scope parameter in the fragment 
> ---------------------------------------------------------------------------
>
>                 Key: AMBER-64
>                 URL: https://issues.apache.org/jira/browse/AMBER-64
>             Project: Amber
>          Issue Type: Bug
>            Reporter: Stein Welberg
>            Assignee: Antonio Sanso
>         Attachments: AMBER-64_improved.patch
>
>
> According to the spec (see [0]) the scope parameter also needs to be included 
> in the url fragment if it is provided.
> Please find the patch attached to fix this attached to this issue.
> [0] http://tools.ietf.org/html/rfc6749#section-4.2.2

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to