The [Type, Method, Field]Descriptor API looks neat - I have two comments
on this:
* I believe the name descriptor is going to be confusing with the rest
of the API, as there are a lot of classes whose name ends with 'Desc'
* we discussed internally to sprinkle parameters on
java/lang/reflect/Member (e.g. have a type parameter T <:
TypeDescriptor<T>, and have a method type() which returns a T). That way
we could have Member to be a full live representation of a reflective
member, including access to owner (a Class<?>), name (String) and,
finally, a type (some TypeDescriptor T).
Maurizio
On 04/05/18 20:09, Vicente Romero wrote:
please review another iteration of the constants API at [3]. This one
removes the Lookup argument from describeConstable() plus adds
interfaces FieldDescriptor, TypeDescriptor and MethodDescriptor
Thanks,
Vicente
[3]
http://cr.openjdk.java.net/~vromero/constant.api/webrev.01/constants.api.patch
On 05/01/2018 01:43 PM, Brian Goetz wrote:
To be clear: we’re asking for an *API review*. No need to review the
code right now, just the API and the specs.
On May 1, 2018, at 6:32 PM, Vicente Romero
<[email protected]> wrote:
Please review also the related CSR:
https://bugs.openjdk.java.net/browse/JDK-8202031
Thanks,
Vicente
On 04/27/2018 01:31 PM, Vicente Romero wrote:
Hi all,
Please review the current proposal of the constants API, which are
nominal descriptor types defined in pkg java.lang.invoke.constant.
The code can be found at [1]. This API is being developed in the
context of JEP 303: Intrinsics for the LDC and INVOKEDYNAMIC
Instructions [2]
Thanks in advance for your comments,
Vicente
[1] http://cr.openjdk.java.net/~vromero/constant.api/webrev.00
[2] http://openjdk.java.net/jeps/303
