[AMD Official Use Only - General] This patch is,
Reviewed-by: Tim Huang <tim.hu...@amd.com> > -----Original Message----- > From: Jesse Zhang <jesse.zh...@amd.com> > Sent: Friday, May 10, 2024 10:51 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander <alexander.deuc...@amd.com>; Koenig, Christian > <christian.koe...@amd.com>; Huang, Tim <tim.hu...@amd.com>; Zhang, > Jesse(Jie) <jesse.zh...@amd.com>; Zhang, Jesse(Jie) > <jesse.zh...@amd.com> > Subject: [PATCH 15/22] drm/amd/pm: fix enum feature compared against 0 > > This less-than-zero comparison of an unsigned value is never true. feature < > 0U > > Signed-off-by: Jesse Zhang <jesse.zh...@amd.com> > --- > drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c > b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c > index 6d1c3af927ca..d439b95bfb79 100644 > --- a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c > @@ -760,7 +760,7 @@ static const char *__smu_feature_names[] = > { static const char *smu_get_feature_name(struct smu_context *smu, > enum smu_feature_mask feature) > { > - if (feature < 0 || feature >= SMU_FEATURE_COUNT) > + if (feature >= SMU_FEATURE_COUNT) > return "unknown smu feature"; > return __smu_feature_names[feature]; > } > -- > 2.25.1