Allow any of the se/sh/instance fields to be
specified as a broadcast by submitting 0x3FF.

(v2) Fix broadcast range checking

Signed-off-by: Tom St Denis <tom.stde...@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 4217e754f99e..04c4aee70452 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -2574,6 +2574,13 @@ static ssize_t amdgpu_debugfs_regs_read(struct file *f, 
char __user *buf,
                se_bank = (*pos >> 24) & 0x3FF;
                sh_bank = (*pos >> 34) & 0x3FF;
                instance_bank = (*pos >> 44) & 0x3FF;
+
+               if (se_bank == 0x3FF)
+                       se_bank = 0xFFFFFFFF;
+               if (sh_bank == 0x3FF)
+                       sh_bank = 0xFFFFFFFF;
+               if (instance_bank == 0x3FF)
+                       instance_bank = 0xFFFFFFFF;
                use_bank = 1;
        } else {
                use_bank = 0;
@@ -2582,8 +2589,8 @@ static ssize_t amdgpu_debugfs_regs_read(struct file *f, 
char __user *buf,
        *pos &= 0x3FFFF;
 
        if (use_bank) {
-               if (sh_bank >= adev->gfx.config.max_sh_per_se ||
-                   se_bank >= adev->gfx.config.max_shader_engines)
+               if ((sh_bank != 0xFFFFFFFF && sh_bank >= 
adev->gfx.config.max_sh_per_se) ||
+                   (se_bank != 0xFFFFFFFF && se_bank >= 
adev->gfx.config.max_shader_engines))
                        return -EINVAL;
                mutex_lock(&adev->grbm_idx_mutex);
                amdgpu_gfx_select_se_sh(adev, se_bank,
-- 
2.10.0

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reply via email to