From: Xiangliang Yu <xiangliang...@amd.com>

Wptr number should be align with buf_mask, otherwise will point
to wrong place.

Signed-off-by: Xiangliang Yu <xiangliang...@amd.com>
Signed-off-by: Monk Liu <monk....@amd.com>
Reviewed-by: Ken Wang <qingqing.w...@amd.com>
Reviewed-by: Christian König <christian.koe...@amd.com>
Signed-off-by: Alex Deucher <alexander.deuc...@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c 
b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
index 8e5367d..ad82ab7 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
@@ -3275,7 +3275,7 @@ static unsigned gfx_v9_0_ring_emit_init_cond_exec(struct 
amdgpu_ring *ring)
        amdgpu_ring_write(ring, lower_32_bits(ring->cond_exe_gpu_addr));
        amdgpu_ring_write(ring, upper_32_bits(ring->cond_exe_gpu_addr));
        amdgpu_ring_write(ring, 0); /* discard following DWs if 
*cond_exec_gpu_addr==0 */
-       ret = ring->wptr;
+       ret = ring->wptr & ring->buf_mask;
        amdgpu_ring_write(ring, 0x55aa55aa); /* patch dummy value later */
        return ret;
 }
@@ -3283,9 +3283,10 @@ static unsigned gfx_v9_0_ring_emit_init_cond_exec(struct 
amdgpu_ring *ring)
 static void gfx_v9_0_ring_emit_patch_cond_exec(struct amdgpu_ring *ring, 
unsigned offset)
 {
        unsigned cur;
+       BUG_ON(offset > ring->buf_mask);
        BUG_ON(ring->ring[offset] != 0x55aa55aa);
 
-       cur = ring->wptr - 1;
+       cur = (ring->wptr & ring->buf_mask) - 1;
        if (likely(cur > offset))
                ring->ring[offset] = cur - offset;
        else
-- 
2.5.5

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reply via email to