[PATCH 3/8] drm/amdgpu/gfx8: reserve mqd objects before mapping them

[Alex Deucher]

It's required.

Signed-off-by: Alex Deucher <alexander.deuc...@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 32 +++++++++++++++++++++-----------
 1 file changed, 21 insertions(+), 11 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c 
b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
index 8e30cb0..efe03a5 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
@@ -4936,31 +4936,40 @@ static int gfx_v8_0_kiq_resume(struct amdgpu_device 
*adev)
        gfx_v8_0_cp_compute_enable(adev, true);
 
        ring = &adev->gfx.kiq.ring;
-       if (!amdgpu_bo_kmap(ring->mqd_obj, &ring->mqd_ptr)) {
+
+       r = amdgpu_bo_reserve(ring->mqd_obj, false);
+       if (unlikely(r != 0))
+               goto done;
+
+       r = amdgpu_bo_kmap(ring->mqd_obj, &ring->mqd_ptr);
+       if (!r) {
                r = gfx_v8_0_kiq_init_queue(ring,
                                            (struct vi_mqd *)ring->mqd_ptr,
                                            ring->mqd_gpu_addr);
                amdgpu_bo_kunmap(ring->mqd_obj);
                ring->mqd_ptr = NULL;
-               if (r)
-                       return r;
-       } else {
-               return r;
        }
+       amdgpu_bo_unreserve(ring->mqd_obj);
+       if (r)
+               goto done;
 
        for (i = 0; i < adev->gfx.num_compute_rings; i++) {
                ring = &adev->gfx.compute_ring[i];
-               if (!amdgpu_bo_kmap(ring->mqd_obj, &ring->mqd_ptr)) {
+
+               r = amdgpu_bo_reserve(ring->mqd_obj, false);
+               if (unlikely(r != 0))
+                       goto done;
+               r = amdgpu_bo_kmap(ring->mqd_obj, &ring->mqd_ptr);
+               if (!r) {
                        r = gfx_v8_0_kiq_init_queue(ring,
                                                    (struct vi_mqd 
*)ring->mqd_ptr,
                                                    ring->mqd_gpu_addr);
                        amdgpu_bo_kunmap(ring->mqd_obj);
                        ring->mqd_ptr = NULL;
-                       if (r)
-                       return r;
-               } else {
-                       return r;
                }
+               amdgpu_bo_unreserve(ring->mqd_obj);
+               if (r)
+                       goto done;
        }
 
        for (i = 0; i < adev->gfx.num_compute_rings; i++) {
@@ -4978,7 +4987,8 @@ static int gfx_v8_0_kiq_resume(struct amdgpu_device *adev)
        if (r)
                ring->ready = false;
 
-       return 0;
+done:
+       return r;
 }
 
 static int gfx_v8_0_cp_resume(struct amdgpu_device *adev)
-- 
2.5.5

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx