On Tue, May 23, 2017 at 2:47 PM, Deucher, Alexander <alexander.deuc...@amd.com> wrote: >> -----Original Message----- >> From: Lukas Wunner [mailto:lu...@wunner.de] >> Sent: Monday, May 22, 2017 11:51 PM >> To: Michel Dänzer >> Cc: Nicolai Stange; Sean Paul; Deucher, Alexander; dri- >> de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; Koenig, >> Christian >> Subject: Re: [PATCH] drm/radeon: Fix oops upon driver load on PowerXpress >> laptops >> >> On Tue, May 23, 2017 at 12:09:49PM +0900, Michel Dänzer wrote: >> > On 22/05/17 11:04 PM, Lukas Wunner wrote: >> > > On Sun, May 21, 2017 at 09:31:09AM +0200, Nicolai Stange wrote: >> > >> On Thu, May 18 2017, Lukas Wunner wrote: >> > > [snip] >> > >>> Reported-by: Nicolai Stange <nicsta...@gmail.com> >> > >>> Fixes: 7ffb0ce31cf9 ("drm/radeon: Don't register Thunderbolt eGPU >> with vga_switcheroo") >> > >>> Signed-off-by: Lukas Wunner <lu...@wunner.de> >> > >>> --- >> > >>> >> > >>> Awaiting a Tested-by: from Nicolai, but it's clear this is a bug and >> > >>> needs to be fixed, so sending out with a proper commit message now. >> > >>> The bug was only introduced to radeon, not amdgpu. >> > >> >> > >> Tested-by: Nicolai Stange <nicsta...@gmail.com> >> > >> >> > >> Thanks for the quick fix! >> > >> >> > >>> @Alex Deucher: I could push this to drm-misc-fixes but then it >> wouldn't >> > >>> land before -rc3 because Sean Paul has already sent out the -rc2 pull. >> > >>> I notice you haven't sent out a pull for -rc2 yet, so maybe you want to >> > >>> take it yourself? Whichever you prefer. Thanks & sorry for the >> breakage! >> > > >> > > I've learned this morning that Alex is on vacation. >> > >> > Christian König is standing in for Alex. >> >> By his own account, he already has "all hands full replacing him [Alex]", >> explicitly asked Daniel to merge an amdgpu patch through drm-misc-next for >> this reason and lacks permission to update branches in Alex' repo on fdo: >> >> "One lesson learned from the past week is that Alex needs to stop using >> his personal repository on fdo. >> We were asked a couple of times if I couldn't update a branch there from >> different directions, which we obviously can't do." >> >> https://lists.freedesktop.org/archives/dri-devel/2017-May/142376.html >> https://lists.freedesktop.org/archives/dri-devel/2017-May/142380.html >> > > What tree we use for pull requests is irrelevant. We need to follow the > proper protocol. In the future patches like this should have an ack or rb > and should flow through the radeon tree. > >> >> > > I've pushed the patch to drm-misc-fixes so that the issue is fixed in >> > > 4.12-rc3. >> > >> > I don't think there was any particular need to bypass the normal radeon >> > tree for this. There was plenty of time for the fix to get into 4.12 >> > final, even after Alex is back. >> >> Well, it wouldn't be nice towards users affected by the same issue >> who may waste time with bisecting to just sit on a fix twiddling thumbs. > > We also need to try and avoid regressions and try and flow changes through > proper trees. There is always going to be some delay in getting changes > upstream.
Sorry for piling on, I hadn't quite caught up with the whole thread yet. In the end no harm done. Alex > > Alex > >> >> Thanks, >> >> Lukas > _______________________________________________ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
