Applied. Thanks!
On Sun, Apr 28, 2024 at 9:32 PM Zhou, Bob <bob.z...@amd.com> wrote:
>
> [Public]
>
> Reviewed-by: Bob Zhou <bob.z...@amd.com>
>
> Regards,
> Bob
>
> -----Original Message-----
> From: Dan Carpenter <dan.carpen...@linaro.org>
> Sent: 2024年4月28日 20:57
> To: Zhou, Bob <bob.z...@amd.com>
> Cc: Deucher, Alexander <alexander.deuc...@amd.com>; Koenig, Christian
> <christian.koe...@amd.com>; Pan, Xinhui <xinhui....@amd.com>; David Airlie
> <airl...@gmail.com>; Daniel Vetter <dan...@ffwll.ch>; Kuehling, Felix
> <felix.kuehl...@amd.com>; Zhang, Hawking <hawking.zh...@amd.com>; Guchun Chen
> <guchun.c...@amd.com>; Ma, Le <le...@amd.com>; Lazar, Lijo
> <lijo.la...@amd.com>; Sharma, Shashank <shashank.sha...@amd.com>;
> amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org;
> linux-ker...@vger.kernel.org; kernel-janit...@vger.kernel.org
> Subject: [PATCH] drm/amdgpu: Fix signedness bug in
> sdma_v4_0_process_trap_irq()
>
> The "instance" variable needs to be signed for the error handling to work.
>
> Fixes: b34ddc71267a ("drm/amdgpu: add error handle to avoid out-of-bounds")
> Signed-off-by: Dan Carpenter <dan.carpen...@linaro.org>
> ---
> drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> index 101038395c3b..772604feb6ac 100644
> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> @@ -2017,7 +2017,7 @@ static int sdma_v4_0_process_trap_irq(struct
> amdgpu_device *adev,
> struct amdgpu_irq_src *source,
> struct amdgpu_iv_entry *entry) {
> - uint32_t instance;
> + int instance;
>
> DRM_DEBUG("IH: SDMA trap\n");
> instance = sdma_v4_0_irq_id_to_seq(entry->client_id);
> --
> 2.43.0
>
