On 2024-05-29 23:48, Jesse Zhang wrote:
If the rewind flag is set, it should return the final result of setting mes debug mode or refresh the run list.
No. We're rewinding because an error occurred. We want to return that error, not the success probably returned by refreshing the runlist.
Regards, Felix
Signed-off-by: Jesse Zhang <jesse.zh...@amd.com> --- drivers/gpu/drm/amd/amdkfd/kfd_debug.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_debug.c b/drivers/gpu/drm/amd/amdkfd/kfd_debug.c index 4abd275056d6..d12e5f29919a 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_debug.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_debug.c @@ -548,9 +548,9 @@ int kfd_dbg_trap_set_flags(struct kfd_process *target, uint32_t *flags) continue;if (!pdd->dev->kfd->shared_resources.enable_mes)- debug_refresh_runlist(pdd->dev->dqm); + r = debug_refresh_runlist(pdd->dev->dqm); else - kfd_dbg_set_mes_debug_mode(pdd, true); + r = kfd_dbg_set_mes_debug_mode(pdd, true); } }
