Since the range of align is 0~7, the expression is: align = (attr >> 3) & 7.
In the case of ATOM_ARG_IMM, the code cannot reach the default case.
So there is no need for "break".

Signed-off-by: Jesse Zhang <jesse.zh...@amd.com>
Suggested-by: Tim Huang <tim.hu...@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/atom.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/atom.c 
b/drivers/gpu/drm/amd/amdgpu/atom.c
index d552e013354c..09715b506468 100644
--- a/drivers/gpu/drm/amd/amdgpu/atom.c
+++ b/drivers/gpu/drm/amd/amdgpu/atom.c
@@ -301,7 +301,7 @@ static uint32_t atom_get_src_int(atom_exec_context *ctx, 
uint8_t attr,
                        (*ptr) += 4;
                        if (print)
                                DEBUG("IMM 0x%08X\n", val);
-                       return val;
+                       break;
                case ATOM_SRC_WORD0:
                case ATOM_SRC_WORD8:
                case ATOM_SRC_WORD16:
@@ -309,7 +309,7 @@ static uint32_t atom_get_src_int(atom_exec_context *ctx, 
uint8_t attr,
                        (*ptr) += 2;
                        if (print)
                                DEBUG("IMM 0x%04X\n", val);
-                       return val;
+                       break;
                case ATOM_SRC_BYTE0:
                case ATOM_SRC_BYTE8:
                case ATOM_SRC_BYTE16:
@@ -318,9 +318,9 @@ static uint32_t atom_get_src_int(atom_exec_context *ctx, 
uint8_t attr,
                        (*ptr)++;
                        if (print)
                                DEBUG("IMM 0x%02X\n", val);
-                       return val;
+                       break;
                }
-               break;
+               return val;
        case ATOM_ARG_PLL:
                idx = U8(*ptr);
                (*ptr)++;
-- 
2.25.1

Reply via email to