In a series that reworked the CSB manipulation, Christian noticed the use of volatile in some of the function parameters and pointed out that the use of volatile in amdgpu is probably wrong [1]. He also shared the following link about this topic:
https://docs.kernel.org/process/volatile-considered-harmful.html After reading the documentation and inspecting multiple parts of the code, this series was created to remove many parts that use volatile. The three rare cases where volatile should be used served as a guide for making this series. [1] https://lore.kernel.org/amd-gfx/[email protected]/ Thanks Rodrigo Siqueira (5): drm/amdgpu: Remove volatile from CSB functions drm/amdgpu: Remove volatile from RLC files drm/amdgpu: Remove volatile from ring manipulation drm/amdgpu: Remove volatile from amdgpu and amdgpu_ih headers drm/amdgpu: Remove volatile references from VCN drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 6 +++--- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 6 +++--- drivers/gpu/drm/amd/amdgpu/amdgpu_ih.h | 6 +++--- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 12 ++++++------ drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.h | 8 ++++---- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 10 +++++----- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 5 ++--- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 5 ++--- drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c | 5 ++--- drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 7 +++---- drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 5 ++--- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 3 +-- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 3 +-- drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 10 +++++----- drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 10 +++++----- drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 12 ++++++------ drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c | 14 +++++++------- drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c | 12 ++++++------ drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c | 10 +++++----- drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.c | 10 +++++----- drivers/gpu/drm/amd/amdgpu/vcn_v5_0_1.c | 12 ++++++------ 24 files changed, 87 insertions(+), 94 deletions(-) -- 2.50.1
