On Thu, Sep 25, 2025 at 5:33 PM Timur Kristóf <[email protected]> wrote: > > > > Alex Deucher <[email protected]> ezt írta (időpont: 2025. szept. 25., Csü > 23:28): >> >> On Thu, Sep 25, 2025 at 2:45 PM Timur Kristóf <[email protected]> >> wrote: >> > >> > Without these, it's impossible to program these registers. >> > >> > Fixes: 102b2f587ac8 ("drm/amd/display: dce_transform: DCE6 Scaling >> > Horizontal Filter Init (v2)") >> > Signed-off-by: Timur Kristóf <[email protected]> >> >> I think it would make sense to just squash patches 2-4 together. >> Other than that, these look good to me. >> >> Alex > > > They make more sense to me individually but we can squash them too. Do you > prefer that I send another series with these squashed or will you squash them > when applying them?
I guess they make sense as is from a Fixes tag perspective, but from an overall functional perspective it's easier to just have one patch. I'll just apply them as is. Series is: Reviewed-by: Alex Deucher <[email protected]> Alex > > >> >> > --- >> > drivers/gpu/drm/amd/display/dc/dce/dce_transform.h | 2 ++ >> > 1 file changed, 2 insertions(+) >> > >> > diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_transform.h >> > b/drivers/gpu/drm/amd/display/dc/dce/dce_transform.h >> > index cbce194ec7b8..ff746fba850b 100644 >> > --- a/drivers/gpu/drm/amd/display/dc/dce/dce_transform.h >> > +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_transform.h >> > @@ -155,6 +155,8 @@ >> > SRI(SCL_COEF_RAM_TAP_DATA, SCL, id), \ >> > SRI(VIEWPORT_START, SCL, id), \ >> > SRI(VIEWPORT_SIZE, SCL, id), \ >> > + SRI(SCL_HORZ_FILTER_INIT_RGB_LUMA, SCL, id), \ >> > + SRI(SCL_HORZ_FILTER_INIT_CHROMA, SCL, id), \ >> > SRI(SCL_HORZ_FILTER_SCALE_RATIO, SCL, id), \ >> > SRI(SCL_VERT_FILTER_SCALE_RATIO, SCL, id), \ >> > SRI(SCL_VERT_FILTER_INIT, SCL, id), \ >> > -- >> > 2.51.0 >> >
