[Public] > -----Original Message----- > From: Alex Deucher <[email protected]> > Sent: Thursday, October 9, 2025 3:09 PM > To: Kim, Jonathan <[email protected]> > Cc: [email protected]; Deucher, Alexander > <[email protected]>; Liu, Shaoyun <[email protected]>; > Kasiviswanathan, Harish <[email protected]>; Lin, Amber > <[email protected]> > Subject: Re: [PATCH 4/6] drm/amdgpu: enable suspend/resume all for gfx 12 > > On Thu, Oct 9, 2025 at 2:50 PM Jonathan Kim <[email protected]> wrote: > > > > Suspend/resume all gangs has been available for GFX12 for a while now > > so enable it. > > Is this true for all released gfx12 MES firmwares? If so, > Acked-by: Alex Deucher <[email protected]>
Yes this has been available for all of GFX 12 for a while. Jon > > > > > Signed-off-by: Jonathan Kim <[email protected]> > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 11 ++++------- > > 1 file changed, 4 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c > > index 1af3ddb6f65c..b2f87bc29f00 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c > > @@ -698,14 +698,11 @@ int amdgpu_mes_init_microcode(struct > amdgpu_device *adev, int pipe) > > bool amdgpu_mes_suspend_resume_all_supported(struct amdgpu_device > *adev) > > { > > uint32_t mes_rev = adev->mes.sched_version & > AMDGPU_MES_VERSION_MASK; > > - bool is_supported = false; > > > > - if (amdgpu_ip_version(adev, GC_HWIP, 0) >= IP_VERSION(11, 0, 0) && > > - amdgpu_ip_version(adev, GC_HWIP, 0) < IP_VERSION(12, 0, 0) && > > - mes_rev >= 0x63) > > - is_supported = true; > > - > > - return is_supported; > > + return ((amdgpu_ip_version(adev, GC_HWIP, 0) >= IP_VERSION(11, 0, 0) > && > > + amdgpu_ip_version(adev, GC_HWIP, 0) < IP_VERSION(12, 0, 0) > > && > > + mes_rev >= 0x63) || > > + amdgpu_ip_version(adev, GC_HWIP, 0) >= IP_VERSION(12, 0, > > 0)); > > } > > > > /* Fix me -- node_id is used to identify the correct MES instances in the > > future > */ > > -- > > 2.34.1 > >
