On Thu, Oct 2, 2025 at 1:51 PM Mario Limonciello <[email protected]> wrote: > > Error handling was introduced in commit e095026f0066e ("drm/amdgpu: > validate suspend before function call") so the comment about TODO is no > longer needed. > > Fixes: e095026f0066e ("drm/amdgpu: validate suspend before function call") > Signed-off-by: Mario Limonciello <[email protected]>
Reviewed-by: Alex Deucher <[email protected]> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > index 870969f15735..d8cbfb094920 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > @@ -3773,7 +3773,6 @@ static int amdgpu_device_ip_suspend_phase1(struct > amdgpu_device *adev) > if (adev->ip_blocks[i].version->type != AMD_IP_BLOCK_TYPE_DCE) > continue; > > - /* XXX handle errors */ > r = amdgpu_ip_block_suspend(&adev->ip_blocks[i]); > if (r) > return r; > -- > 2.51.0 >
