--- quoted message --- > From: Robert Beckett <[email protected]> > > Lijo pointed out to me that > > commit ed4efe426a49 ("drm/amd: Restore cached power limit during resume") > > commit 796ff8a7e01b ("drm/amd: Restore cached manual clock settings during > > resume") > > both should be unnecessary because smu_restore_dpm_user_profile() already > > restores them. However in looking at the code there is a case that isn't > > properly restored - the FAST PPT limits supported by Van Gogh. The nuance > > isn't immediately obvious because the limit variable is overloaded with > > limit type. > > This series attempts to address that issue by passing limit type around > > and saving/restoring both types. > > Cc: Lijo Lazar <[email protected]> > > Mario Limonciello (5): > > drm/amd: Remove some unncessary header includes > > drm/amd: Stop overloading power limit with limit type > > drm/amd: Save and restore all limit types > > drm/amd: Drop calls to restore power limit and clock from smu_resume() > > drm/amd: Adjust whitespace for vangogh_ppt > > .../gpu/drm/amd/include/kgd_pp_interface.h | 2 +- > > drivers/gpu/drm/amd/pm/amdgpu_dpm.c | 3 +- > > drivers/gpu/drm/amd/pm/amdgpu_pm.c | 3 +- > > drivers/gpu/drm/amd/pm/inc/amdgpu_dpm.h | 2 +- > > .../gpu/drm/amd/pm/powerplay/amd_powerplay.c | 5 +-- > > drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 40 ++++++++----------- > > drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 3 +- > > .../gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 13 +++--- > > 8 files changed, 29 insertions(+), 42 deletions(-) > > -- > > 2.51.0 > entire series > Tested-by: Robert Beckett <[email protected]>
apologies, I need to retract this Tested-by. I inadvertently tested v1. v2 looks like it still has the restore issue. I'll debug and get back to you.
