Re: [PATCH] drm/amdgpu: Skip SDMA suspend during mode-2 reset

[Alex Deucher]

On Mon, Oct 20, 2025 at 8:31 AM <timur.kris...@gmail.com> wrote:
>
> On Wed, 2025-10-08 at 10:34 +0530, Lijo Lazar wrote:
> > For SDMA IP versions > v4.4.2, firmware will take care of quiescing
> > SDMA
> > before mode-2 reset.
> >
> > Signed-off-by: Lijo Lazar <lijo.la...@amd.com>
> > ---
> >  drivers/gpu/drm/amd/amdgpu/aldebaran.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/aldebaran.c
> > b/drivers/gpu/drm/amd/amdgpu/aldebaran.c
> > index 9569dc16dd3d..0007d00b9e8f 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/aldebaran.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/aldebaran.c
> > @@ -88,6 +88,10 @@ static int aldebaran_mode2_suspend_ip(struct
> > amdgpu_device *adev)
> >       uint32_t ip_block;
> >       int r, i;
> >
> > +     /* Skip suspend of SDMA IP versions > 4.4.2. They are multi-
> > aid */
>
> What does "multi-aid" mean here?

Active Interposer Die.  Multi-chiplet platforms like MI300.

Alex

>
>
> > +     if (adev->aid_mask)
> > +             ip_block_mask &= ~BIT(AMD_IP_BLOCK_TYPE_SDMA);
> > +
> >       amdgpu_device_set_pg_state(adev, AMD_PG_STATE_UNGATE);
> >       amdgpu_device_set_cg_state(adev, AMD_CG_STATE_UNGATE);
> >