On Mon, Oct 20, 2025 at 3:47 PM Rodrigo Siqueira <[email protected]> wrote: > > Lately, I have been part of multiple discussions around GPU recovery and > other concepts associated with GFX/Compute. Most of the debate is spread > around GitLab issues, emails, and some meeting conversations. This > patchset aims to consolidate all that information into a single > kernel-doc, which can be collaboratively improved and shared with other > people. > > In this series, you will find new amdgpu glossary entries, more details > about the IPs' interconnections, and a description of the ring buffer. > This series includes multiple SVG diagrams; for this reason, it might be > good to apply this series locally. However, if you want to check all the > images quickly, check the links below: > > - https://people.igalia.com/siqueira/kernel-doc-imgs/v3/amd_overview_block.svg
Looks good. For completeness, maybe add a path from PSP to the UMC on the right side? Also, I'm not sure it matters for the sake of the drawing, but the memory hubs are not really part of the IPs per se. For example, on navi and newer, GC and SDMA are both attached to GCHUB. On pre-Navi, SDMA goes through MMHUB. VCN, JPEG, and VPE go through MMHUB. DCN goes through DCHUB. > - https://people.igalia.com/siqueira/kernel-doc-imgs/v3/gfx_pipeline_seq.svg > - > https://people.igalia.com/siqueira/kernel-doc-imgs/v3/no_enforce_isolation.svg > - https://people.igalia.com/siqueira/kernel-doc-imgs/v3/enforce_isolation.svg > - https://people.igalia.com/siqueira/kernel-doc-imgs/v3/ring_buffers.svg These look good. Thanks! > > Finally, keep in mind that I tried to fill in some gaps between > information, and hopefully, my description matches the reality. > > Changes since V2: > - Remove the unnecessary diagram. > - Remove the excessive details about hardware behavior that are not > useful for a driver developer. > - Remove some wrong information. > - Rewrite many parts of the ring buffer description. > > Cc: Alex Deucher <[email protected]> > Cc: Christian König <[email protected]> > Cc: Timur Kristóf <[email protected]> > > Thanks > > Rodrigo Siqueira (5): > drm/amdgpu: Expand kernel-doc in amdgpu_ring > Documentation/gpu: Add new glossary entries from UMR > Documentation/gpu: Expand generic block information > Documentation/gpu: Add more information about GC > Documentation/gpu: Add documentation about ring buffer > > .../gpu/amdgpu/amd_overview_block.svg | 674 +++++++ > Documentation/gpu/amdgpu/amdgpu-glossary.rst | 24 + > Documentation/gpu/amdgpu/driver-core.rst | 25 + > .../gpu/amdgpu/enforce_isolation.svg | 654 +++++++ > Documentation/gpu/amdgpu/gc/index.rst | 24 +- > Documentation/gpu/amdgpu/gfx_pipeline_seq.svg | 413 +++++ > Documentation/gpu/amdgpu/index.rst | 1 + > .../gpu/amdgpu/no_enforce_isolation.svg | 707 +++++++ > Documentation/gpu/amdgpu/ring-buffer.rst | 91 + > Documentation/gpu/amdgpu/ring_buffers.svg | 1633 +++++++++++++++++ > Documentation/gpu/amdgpu/userq.rst | 2 + > drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 15 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 2 + > 13 files changed, 4251 insertions(+), 14 deletions(-) > create mode 100644 Documentation/gpu/amdgpu/amd_overview_block.svg > create mode 100644 Documentation/gpu/amdgpu/enforce_isolation.svg > create mode 100644 Documentation/gpu/amdgpu/gfx_pipeline_seq.svg > create mode 100644 Documentation/gpu/amdgpu/no_enforce_isolation.svg > create mode 100644 Documentation/gpu/amdgpu/ring-buffer.rst > create mode 100644 Documentation/gpu/amdgpu/ring_buffers.svg > > -- > 2.51.0 >
