On Fri, 2025-11-14 at 11:40 +0100, Christian König wrote: > On 11/13/25 20:07, Timur Kristóf wrote: > > Now that the DC analog connector support and VCE1 support landed, > > SI dGPUs are at feature parity with the old radeon driver. > > > > Enabling the amdgpu driver by default for SI dGPUs has the > > following benefits: > > > > - More stable OpenGL support through RadeonSI > > - Vulkan support through RADV > > - Improved performance > > - Better display features through DC > > > > Users who want to keep using the old driver can do so using: > > amdgpu.si_support=0 radeon.si_support=1 > > > > Signed-off-by: Timur Kristóf <[email protected]> > > The patch should probably also update the text in the Kconfig file > drivers/gpu/drm/amd/amdgpu/Kconfig.
Nice catch. I will send a second version for both SI and CIK to update the Konfig file as well. > > That currently reads: > > config DRM_AMDGPU_SI > bool "Enable amdgpu support for SI parts" > depends on DRM_AMDGPU > help > Choose this option if you want to enable experimental > support > for SI (Southern Islands) asics. > > SI is already supported in radeon. Experimental support for > SI > in amdgpu will be disabled by default and is still provided > by > radeon. Use module options to override this: > > radeon.si_support=0 amdgpu.si_support=1 > > Same for CIK BTW. > > Apart from that look good to me, > Christian. > > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 + > > drivers/gpu/drm/radeon/radeon_drv.c | 1 + > > 2 files changed, 2 insertions(+) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > > b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > > index 3cf36d28d27f..0539f97fa2f5 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > > @@ -2327,6 +2327,7 @@ static bool amdgpu_support_enabled(struct > > device *dev, > > param = "si_support"; > > module_param = amdgpu_si_support; > > amdgpu_support_built = > > IS_ENABLED(CONFIG_DRM_AMDGPU_SI); > > + support_by_default = true; > > break; > > > > case CHIP_BONAIRE: > > diff --git a/drivers/gpu/drm/radeon/radeon_drv.c > > b/drivers/gpu/drm/radeon/radeon_drv.c > > index 40dff6feac8a..fe7ed70f4703 100644 > > --- a/drivers/gpu/drm/radeon/radeon_drv.c > > +++ b/drivers/gpu/drm/radeon/radeon_drv.c > > @@ -273,6 +273,7 @@ static bool radeon_support_enabled(struct > > device *dev, > > gen = "SI"; > > module_param = radeon_si_support; > > amdgpu_support_built &= > > IS_ENABLED(CONFIG_DRM_AMDGPU_SI); > > + support_by_default = false; > > break; > > > > case CHIP_BONAIRE:
