On Mon, Dec 1, 2025 at 5:24 AM Lijo Lazar <[email protected]> wrote:
>
> This is a follow-up to the series which keeps only emit_clock_levels to print 
> dpm table. This series
> moves the print dpm table to a common helper. Presently, each IP version is 
> maintaining separate dpm
> table structure which is really not required to represent dpm tables. A 
> common dpm table structure
> is used across IP versions. Pcie dpm table follow a different format, hence 
> it is kept separate. A
> helper function is used to print the clock tables in pp_dpm_*clk interface. 
> The function takes the
> common dpm table and current clock. It helps to keep some uniformity in 
> pp_dpm_*clk interface across
> IP versions.

Nice cleanup.  Series is:
Reviewed-by: Alex Deucher <[email protected]>

>
> APUs currently don't use dpm table for printing pp_dpm_*clk, hence they are 
> not moved yet to use the
> helper function.
>
>
> Lijo Lazar (17):
>   drm/amd/pm: Add clock table structure
>   drm/amd/pm: Use generic dpm table for SMUv11 SOCs
>   drm/amd/pm: Use generic dpm table for SMUv13 SOCs
>   drm/amd/pm: Use generic dpm table for SMUv14 SOCs
>   drm/amd/pm: Add generic pcie dpm table
>   drm/amd/pm: Use generic pcie dpm table for SMUv11
>   drm/amd/pm: Use generic pcie dpm table for SMUv13
>   drm/amd/pm: Use generic pcie dpm table for SMUv14
>   drm/amd/pm: Add a helper to show dpm table
>   drm/amd/pm: Use common helper for arcturus dpm
>   drm/amd/pm: Use common helper for navi10 dpm table
>   drm/amd/pm: Use common helper for sienna dpm table
>   drm/amd/pm: Use common helper for aldebaran dpm table
>   drm/amd/pm: Use common helper for smuv13.0.0 dpm
>   drm/amd/pm: Use common helper for smuv13.0.6 dpm
>   drm/amd/pm: Use common helper for smuv13.0.7 dpm
>   drm/amd/pm: Use common helper for smuv14.0.2 dpm
>
>  drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h |  31 ++
>  drivers/gpu/drm/amd/pm/swsmu/inc/smu_v11_0.h  |  49 +--
>  drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0.h  |  47 +--
>  drivers/gpu/drm/amd/pm/swsmu/inc/smu_v14_0.h  |  47 +--
>  .../gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 188 ++++------
>  .../gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c   | 200 ++++------
>  .../amd/pm/swsmu/smu11/sienna_cichlid_ppt.c   | 197 ++++------
>  .../gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c    |  40 +-
>  .../drm/amd/pm/swsmu/smu13/aldebaran_ppt.c    | 249 ++++--------
>  .../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c    |  86 ++---
>  .../drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c  | 205 ++++------
>  .../drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c  | 353 +++++-------------
>  .../drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c  | 205 ++++------
>  .../gpu/drm/amd/pm/swsmu/smu14/smu_v14_0.c    |  81 ++--
>  .../drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c  | 215 ++++-------
>  drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c        | 118 ++++++
>  drivers/gpu/drm/amd/pm/swsmu/smu_cmn.h        |  10 +
>  17 files changed, 857 insertions(+), 1464 deletions(-)
>
> --
> 2.49.0
>

Reply via email to