On Wed, Jan 7, 2026 at 11:37 AM Xiaogang.Chen <[email protected]> wrote:
>
> From: Xiaogang Chen <[email protected]>
>
> Fixes: 68a5940841684 (drm/amdgpu/gart: Add helper to bind VRAM pages (v2)")
>
> Use dst input parameter to setup gart page table entries instead of using 
> fixed
> location.
>
> Signed-off-by: Xiaogang Chen <[email protected]>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c 
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c
> index 16c3b78e50cb..68d8d0702b45 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c
> @@ -396,7 +396,7 @@ void amdgpu_gart_map_vram_range(struct amdgpu_device 
> *adev, uint64_t pa,
>                 return;
>
>         for (i = 0; i < num_pages; ++i) {
> -               amdgpu_gmc_set_pte_pde(adev, adev->gart.ptr,
> +               amdgpu_gmc_set_pte_pde(adev, (dst ? dst : adev->gart.ptr),

I think you can just use dst directly here.  All of the callers set
this.  Either way, please update the documentation above the function
to reflect the desired behavior.

Alex

>                         start_page + i, pa + AMDGPU_GPU_PAGE_SIZE * i, flags);
>         }
>
> --
> 2.34.1
>

Reply via email to