Hi, I noticed that in drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c, the function smu7_patch_dependency_tables_with_leakage() checks the return values of 12 patch functions:
- smu7_patch_vddc() - smu7_patch_vddci() - smu7_patch_vce_vddc() - smu7_patch_uvd_vddc() - smu7_patch_vddc_shed_limit() - smu7_patch_samu_vddc() - smu7_patch_acp_vddc() - smu7_patch_limits_vddc() (called twice) - smu7_patch_cac_vddc() However, all of these functions always return 0. They call smu7_patch_ppt_v0_with_vdd_leakage() which is a void function, and there are no error paths in any of the patch functions. Is this intentional defensive coding for potential future changes, or could this be cleaned up? Thanks, Ingyu Jang
